feat(cli) - Runtime binary for Deno #8944

yos1p · 2020-12-31T07:35:59Z

deno_runtime crate will produce lite binary: deno-rt in target folder (#8757)

lucacasonato · 2020-12-31T11:22:47Z

This looks good, but could you split the PR so this PR only adds the deno-rt binary? Then we can change how deno compile works in a follow up PR.

yos1p · 2020-12-31T13:10:59Z

Okay. I reverted some of the changes in Deno compile. I also move some of the code from cli/standalone.rs to runtime/standalone.rs. Running from CLI should will call run function from runtime crate now.

bartlomieju

@yos1p looks good, nice work!

That said I'm not sure if we should add a binary target to deno_runtime, maybe instead we should add a second binary target to cli? (I know I suggested to put it in the runtime dir in the original issue, but I'm having doubts now). With this change concepts of standalone binaries are split into cli and runtime and I believe it's preferable to have all of that code in cli.

@ry WDYT?

bartlomieju · 2020-12-31T14:37:31Z

Also we need to track the size of the "lite" binary in the benchmarks: https://deno.land/benchmarks#executable-size I'll be fine to add that in a separate PR though.

ry

Looks good - but can we bike shed on the name of executable a bit?

Generally we avoid dashes in filenames. "rt" is not very intelligible.

What about denolite ?

bartlomieju · 2020-12-31T14:42:06Z

Looks good - but can we bike shed on the name of executable a bit?

Generally we avoid dashes in filenames. "rt" is not very intelligible.

What about denolite ?

Good point, +1 for denolite

lucacasonato · 2020-12-31T14:55:04Z

denolite sounds like a lite version of Deno for general use. But it is not. It is purely the runtime for standalone executable. I would prefer denort or denoruntime.

yos1p · 2020-12-31T17:00:38Z

Thank you for review! Okay. I'll try to move the code and binary to be generated by cli crate.

Also we need to track the size of the "lite" binary in the benchmarks: https://deno.land/benchmarks#executable-size I'll be fine to add that in a separate PR though.

I can do it in this PR.

For the naming, I kind of prefer denort instead of denolite, but name can be easily changed later. I'll just follow what you guys decide.

cli/standalone.rs

ry

Generally looks good @yos1p.

When I run denort in without an arguments I get a zero exit code (success) and no output. I think this is going to be confusing to people who don't know about this. It would be better to print an error message and have a non-zero exit code.

cli/denort.rs

ry

I think we need to have a test of some sort... How will we know if this thing breaks?

yos1p · 2021-01-06T12:40:48Z

I think we need to have a test of some sort... How will we know if this thing breaks?

I think we can use similar tests like standalone, but this can only be applied when we already implement compile with denort instead of deno.

yos1p · 2021-01-06T12:42:02Z

cli/denort.rs

+
+  // TODO (yos1p) Specify better error message
+  eprintln!(
+    "{}: Runtime Error.",


@ry Any suggestions for the error message?

@yos1p this is fine for now, I will review this PR in more detail today/tomorrow and merge it. @lucacasonato and I will look into using this new binary target for standalone executables.

"This executable is used internally by 'deno compile', it is not meant to be invoked directly."

bartlomieju · 2021-01-07T16:52:52Z

@yos1p thank you for the PR, I really appreciate it, but @lucacasonato and I took a deeper look at it and we found out we needed to do a lot more changes. We've opened a new PR at #9041. Closing without merge.

yos1p · 2021-01-07T17:34:02Z

No worries. Looking forward for the new PR!

yos1p added 6 commits December 31, 2020 13:59

proposal for lite binary

ff369cf

fix formatting and lint

443b67e

fix deno-rt dir

b7bc053

Fix standalone args

da1d8f8

fix runtime for windows release

1a72ff4

fix deno-rt extension for windows build

5b8c15a

yos1p added 2 commits December 31, 2020 18:44

Revert changes on Deno compile

4346d61

Fix standalone error

c550e49

yos1p marked this pull request as ready for review December 31, 2020 13:08

bartlomieju reviewed Dec 31, 2020

View reviewed changes

ry reviewed Dec 31, 2020

View reviewed changes

move denort to cli crate

b77ca71

yos1p added 2 commits January 1, 2021 00:35

Fix denort code and lint

89c0775

rustfmt cli/main.rs

c444a41

yos1p marked this pull request as draft December 31, 2020 17:52

track binary size of denort in benchmarks

a4053e0

yos1p changed the title ~~Lite binary for Deno~~ feat(cli) - Runtime binary for Deno Jan 1, 2021

add deny warning check for denort

580d3e4

yos1p commented Jan 1, 2021

View reviewed changes

cli/standalone.rs Outdated Show resolved Hide resolved

move args to run fn

a518c2e

yos1p marked this pull request as ready for review January 1, 2021 03:59

yos1p added 3 commits January 2, 2021 20:31

Merge remote-tracking branch 'upstream/master' into lite-binary

08803e9

Merge remote-tracking branch 'upstream/master' into lite-binary

7931e26

Fix lint and formatting

d84104a

minor changes in main.rs

09ee294

yos1p requested review from ry and bartlomieju January 5, 2021 08:29

ry reviewed Jan 5, 2021

View reviewed changes

cli/denort.rs Outdated Show resolved Hide resolved

ry reviewed Jan 5, 2021

View reviewed changes

yos1p added 2 commits January 6, 2021 18:36

Merge remote-tracking branch 'upstream/master' into lite-binary

7deb351

Throw non-zero exit for denort

6046045

yos1p commented Jan 6, 2021

View reviewed changes

yos1p added 3 commits January 6, 2021 19:48

Fix fmt

73df12c

Fix error message for denort

85806af

Trigger github actions

339ff25

bartlomieju closed this Jan 7, 2021

yos1p deleted the lite-binary branch January 7, 2021 17:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cli) - Runtime binary for Deno #8944

feat(cli) - Runtime binary for Deno #8944

yos1p commented Dec 31, 2020 •

edited

Loading

lucacasonato commented Dec 31, 2020

yos1p commented Dec 31, 2020

bartlomieju left a comment

bartlomieju commented Dec 31, 2020

ry left a comment •

edited

Loading

bartlomieju commented Dec 31, 2020

lucacasonato commented Dec 31, 2020

yos1p commented Dec 31, 2020 •

edited

Loading

ry left a comment •

edited

Loading

ry left a comment

yos1p commented Jan 6, 2021

yos1p Jan 6, 2021

bartlomieju Jan 6, 2021

ry Jan 6, 2021

bartlomieju commented Jan 7, 2021

yos1p commented Jan 7, 2021

feat(cli) - Runtime binary for Deno #8944

feat(cli) - Runtime binary for Deno #8944

Conversation

yos1p commented Dec 31, 2020 • edited Loading

lucacasonato commented Dec 31, 2020

yos1p commented Dec 31, 2020

bartlomieju left a comment

Choose a reason for hiding this comment

bartlomieju commented Dec 31, 2020

ry left a comment • edited Loading

Choose a reason for hiding this comment

bartlomieju commented Dec 31, 2020

lucacasonato commented Dec 31, 2020

yos1p commented Dec 31, 2020 • edited Loading

ry left a comment • edited Loading

Choose a reason for hiding this comment

ry left a comment

Choose a reason for hiding this comment

yos1p commented Jan 6, 2021

yos1p Jan 6, 2021

Choose a reason for hiding this comment

bartlomieju Jan 6, 2021

Choose a reason for hiding this comment

ry Jan 6, 2021

Choose a reason for hiding this comment

bartlomieju commented Jan 7, 2021

yos1p commented Jan 7, 2021

yos1p commented Dec 31, 2020 •

edited

Loading

ry left a comment •

edited

Loading

yos1p commented Dec 31, 2020 •

edited

Loading

ry left a comment •

edited

Loading